Importing multiple images

pedgarcia · 10-27-2009, 03:22 PM

Hi,

I've using Sigil to make epubs from some comics my kids like to read. In this particular comic book, each page contains several images (basically rows of images). To import these images to Sigil is painful because I need to do it one by one.

To help me in this task, I've modified Sigil to import multiples images at once, inserting a line break between images.

Just in case you think it can be useful for others and incorporated in the official source, the source code is attached here.

BTW, very nice job (code-wise speaking)!

Regards

Paulo

Valloric · 10-27-2009, 07:30 PM

The feature looks nice. I'll add it.

But in the future, do please create enhancement requests on the tracker. If you have a diff to submit, just attach it to the issue. Better yet, since Google Code allows for user Mercurial clones since a few weeks ago, you could have just created a personal clone, pushed your changes to it and then requested a pull.

Although this is small enough that it's not really a problem.

pedgarcia · 10-27-2009, 07:48 PM

Hi,

glad you liked it.

I don't have experience with Google code but I'll learn about you said and send updates in the proper way.

Regards

Paulo

Valloric · 10-27-2009, 07:53 PM

This functionality is now in the repo. My version doesn't add <br/> tags after images since those can screw up ADE if they are direct children of the <body> element.

The more important reason why <br> tags are not added is because Word 2007 inserts multiple images inline and not separated by a line break. Sigil tries to conform to standard practices when it can, Word being the gold standard for text editors.

pedgarcia · 10-28-2009, 09:08 AM

Hi,

yes, the <br> between images is convenient for me, but I think you're right to keep the standard practices.

Maybe in the future, if different behaviors for the same feature are necessary you could consider add an Configuration option page that allow the user changing the default.

Regards

Paulo

Valloric · 10-28-2009, 12:38 PM

Quote:

Originally Posted by pedgarcia

Maybe in the future, if different behaviors for the same feature are necessary you could consider add an Configuration option page that allow the user changing the default.

Yes, an "Options" page is on my TODO list.

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
mass-importing ebooks in multiple formats?	hakan42	Calibre	18	02-28-2010 08:06 PM
In Design CS3 creates multiple copies of same images!	paulgodard	Workshop	2	12-13-2009 10:22 AM
importing html does not import images	reup	Calibre	12	12-08-2009 08:52 PM
Importing multiple files into Mobi Reader	Calamity	Bookeen	0	07-25-2008 10:57 AM
Convert multiple images(comics) to PDF - MAC	stustaff	Sony Reader	2	11-28-2007 10:31 AM

10-27-2009, 07:30 PM	#2
Valloric Created Sigil, FlightCrew Posts: 1,982 Karma: 350515 Join Date: Feb 2008 Device: Kobo Clara HD	The feature looks nice. I'll add it. But in the future, do please create enhancement requests on the tracker. If you have a diff to submit, just attach it to the issue. Better yet, since Google Code allows for user Mercurial clones since a few weeks ago, you could have just created a personal clone, pushed your changes to it and then requested a pull. Although this is small enough that it's not really a problem.

10-27-2009, 07:48 PM	#3
pedgarcia Connoisseur Posts: 63 Karma: 250 Join Date: Jul 2009 Device: PRS-505	Hi, glad you liked it. I don't have experience with Google code but I'll learn about you said and send updates in the proper way. Regards Paulo

10-27-2009, 07:53 PM	#4
Valloric Created Sigil, FlightCrew Posts: 1,982 Karma: 350515 Join Date: Feb 2008 Device: Kobo Clara HD	This functionality is now in the repo. My version doesn't add <br/> tags after images since those can screw up ADE if they are direct children of the <body> element. The more important reason why <br> tags are not added is because Word 2007 inserts multiple images inline and not separated by a line break. Sigil tries to conform to standard practices when it can, Word being the gold standard for text editors.

10-28-2009, 09:08 AM	#5
pedgarcia Connoisseur Posts: 63 Karma: 250 Join Date: Jul 2009 Device: PRS-505	Hi, yes, the <br> between images is convenient for me, but I think you're right to keep the standard practices. Maybe in the future, if different behaviors for the same feature are necessary you could consider add an Configuration option page that allow the user changing the default. Regards Paulo

Advert

Advert