Plugin changes to images not reflected until Sigil restart

[rubeus]

I have something similar like this in addition. If i use my AdustSVG plugin und the dimensions needs to be changed the file isnt displayed properly. Restarting Sigil and everything is fine. This i can reprduce it happens in each and every book im treating like this on Sigil 092 Win7 64.

Example:

Call Plugin AdjustSVG in codeview
After values have been corrected switch to bookview => Picture is too big and not centered nor dies it fit in the canvas

[DiapDealer]

Originally Posted by rubeus

I have something similar like this in addition. If i use my AdustSVG plugin und the dimensions needs to be changed the file isnt displayed properly. Restarting Sigil and everything is fine. This i can reprduce it happens in each and every book im treating like this on Sigil 092 Win7 64.

You're talking about the dimensions of a "standard" SVG wrapper like around a cover (or other) image?

[DiapDealer]

Originally Posted by rubeus

I've added an example... This is reproducable on my Computer. Changing the CSS and the changes are not reflected i can observe, too. But i cant reproduce it or give an example.
The svg wrapped image may help to find the root cause for this. May be not. Its the only reproducible problem i currently have where the bookview does not follow code changes.

I'm not quite following. Should I be able to change the dimensions of an image with your plugin? Or are you talking about just adding an image with your plugin and then manually changing the dimensions in Code View?

If it's the latter, both Book View and and Preview immediately reflect the dimension-changes I make (in Code View) to the svg wrapper (on both Windows 7 and Linux).

[rubeus]

The example file contains an svg wrapped image with false dimension. Display in bookview is ok. After correcting it with my plugin in codeview and then switch to bookview its not displayed as it should.

[DiapDealer]

Originally Posted by rubeus

The example file contains an svg wrapped image with false dimension. Display in bookview is ok. After correcting it with my plugin in codeview and then switch to bookview its not displayed as it should.

How do you "correct it" with your plugin? I only see the ability to create new xhtml files from images.

[rubeus]

I'm using AdjustSVG, not AddimgasSVG

[DiapDealer]

Originally Posted by rubeus

I'm using AdjustSVG, not AddimgasSVG

Well duh ... that would make a difference, I guess!

[DiapDealer]

Ok. So I still can't experience the problem. When running the AdjustSVG plugin on Windows Vista/Windows 7, the change in dimensions is immediately reflected in Book View/Preview.

[rubeus]

I was afraid of that that it works on your installation

[DiapDealer]

Originally Posted by rubeus

I was afraid of that that it works on your installation

Actually, no wait. I seem to be experiencing the same thing you are (from your thumbnails). I just assumed you meant that changing the dimensions didn't change the image at all. It seems to take a Sigil restart for the 100% width/height settings kick in.

Manually making the same dimension-changes in Code View does properly update the Book View/Preview display, however, so I can confirm that something funky is going on here. I am going to split this out into its own conversation, though.

[KevinH]

Webkit (BV/PV) will not reload resources unless we invalidate the cache. We do that when resources are added or deleted atomatically in the plugin runner code. But xhtml should always be updated in PV BV when modified by the plugin. Exactly what is the plugin changing? Is it code in an xhtml file or code in a standalone svg image resource?

[DiapDealer]

It's changing the code in an xhtml file. Specifically, the dimension/viewport attributes of an svg-wrapped jpeg image.

Steps:
Install the AdjustSVG plugin/download z.epub
Open z.epub
Run AdjustSVG plugin
See the image exceed the canvas in Book View/Preview

You can switch tabs between Code View/Book View or close/reopen the html resource tab, but it won't fill the canvas like it's supposed to until you either save and restart Sigil, or you save and close the html resource tab and reopen it (you'll probably have to open the image resource tab to be able to close the html resource one).

The Mend Preference settings make no difference.

[KevinH]

Hi,

I can recreate this but, I have triple checked and we are properly clearing the memory caches which should force both PV and BV to reload its resources. I have also tried sending the FlowTab a signal directly to reload BV after clearing the caches but still nothing changes.

This is going to be another of those bugs. This should be properly done. Not sure why it isn't.

[DiapDealer]

I've found that running Mend Code will make it appear correctly, too (one may have to switch from Book View to Code View and back, but Preview updates immediately after running Mend).

Which all leads me to believe that even though there's nothing technically wrong with the xtml file the AdjustSVG plugin is producing/modifying, that there's something there that WebKit just doesn't like.

In Code View--with Preview Open--After you run the AdjustSVG plugin you can right-click and do Reformat HTML->Mend Code and you can then right-click and "Undo" and "Redo." In this way, you can toggle the image from correct to wrong, while watching the code change in Code View. It's very subtle, but Mend seems to be "fixing" things in the xml declaration and the DOCTYPE only.

Ahhh! It's actually the preserveAspectRatio attribute. Something is lower-casing that entire attribute name. Since I don't see that being set in the plugin, it almost has to be in either sigil_bs4.serialize_xhtml() or something else after.

[rubeus]

Yes i'm using the bs4 and i'm not modifying the attributes directly, only their values. Then serializing and writing back...