09-08-2012, 08:27 PM | #16 | |
US Navy, Retired
Posts: 9,864
Karma: 13806776
Join Date: Feb 2009
Location: North Carolina
Device: Icarus Illumina XL HD, Nexus 7
|
FYI
Quote:
I never mentioned it during these discussions because Kovid can't recreate it and I don't give a hoot about 4k every 5-8 seconds. If it ever became an issue I would simply program a reboot periodically to manage it. My linux router reboots on its own about every 10 days. This is very unusual for a linux based router, I just scheduled a reboot once a week on my schedule and life goes on. |
|
09-09-2012, 02:56 AM | #17 | |
Wizard
Posts: 3,720
Karma: 1759970
Join Date: Sep 2010
Device: none
|
Quote:
if someone with Win 7 64 bit can honestly claim it does NOT happen to them than we may have diagnostic progress... if not then maybe it's a Windows thing. but the "it doesn't happen on my machine so the software is not broken" attitude seems narrow-minded - it's not like I have some obscure no-one-else-uses-it O/S... PS for me, the memory leak is no big deal - I have plenty of RAM & it causes me no grief - but if ever APP I have running leaked like this then it would become a problem. |
|
09-09-2012, 03:50 PM | #18 |
Wizard
Posts: 1,176
Karma: 2431850
Join Date: Sep 2008
Device: IPad Mini 2 Retina
|
As a C++/C# developer, for this type of bug, I would get the user to capture some process dumps, e.g. using DebugDiag, and then I would do some post mortem debugging of the dumps using WinDbg. Is that not an option here? I appreciate Calibre is running within python, but a some level it will be allocating memory from the O/S; WinDbg should give some clues as to what the allocated memory contains.
|
09-10-2012, 12:03 AM | #19 |
creator of calibre
Posts: 43,749
Karma: 22446736
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
|
Actually, thanks to a Eureka moment, and a bit of help from people that could reproduce the problem, I found and fixed the probable source of the leak. See the commit logs if you're interested in what the leak was.
@ShellShock: Funnily enough the leak was in C code, not python code |
09-10-2012, 01:17 AM | #20 |
Wizard
Posts: 3,720
Karma: 1759970
Join Date: Sep 2010
Device: none
|
|
09-10-2012, 07:02 AM | #21 | |
Addict
Posts: 254
Karma: 69786
Join Date: May 2006
Location: Oslo, Norway
Device: Kobo Aura, Sony PRS-650
|
Quote:
It seems that the leak was in the code that checks for newly connected devices. |
|
09-10-2012, 07:19 AM | #22 |
creator of calibre
Posts: 43,749
Karma: 22446736
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
|
It's that one and this one: http://bazaar.launchpad.net/~kovid/c...revision/13212
|
09-14-2012, 02:56 PM | #23 |
Guru
Posts: 776
Karma: 2751519
Join Date: Jul 2010
Location: UK
Device: PW2, Nexus7
|
Thanks Kovid, you've nailed it with 0.8.69
|
09-14-2012, 03:15 PM | #24 |
Well trained by Cats
Posts: 29,662
Karma: 54369090
Join Date: Aug 2009
Location: The Central Coast of California
Device: Kobo Libra2,Kobo Aura2v1, K4NT(Fixed: New Bat.), Galaxy Tab A
|
Hmm!
I am watching Virtual size in Process explorer: Tags, Details, Covers not showing Changing the selected book, changes the usage (up or down). Any idea why? Btw, I did see one 'Grow' from ~306K to ~307K. Have not figured the trigger |
09-14-2012, 03:30 PM | #25 |
Guru
Posts: 776
Karma: 2751519
Join Date: Jul 2010
Location: UK
Device: PW2, Nexus7
|
It seems quite normal for memory usage to change up and down in many applications, but the 4K per 5sec constant increase, (even when not touching calibre), has certainly now stopped.
|
09-14-2012, 10:53 PM | #26 |
creator of calibre
Posts: 43,749
Karma: 22446736
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
|
|
09-15-2012, 10:40 AM | #27 | |
Well trained by Cats
Posts: 29,662
Karma: 54369090
Join Date: Aug 2009
Location: The Central Coast of California
Device: Kobo Libra2,Kobo Aura2v1, K4NT(Fixed: New Bat.), Galaxy Tab A
|
Quote:
Something made it go up a Bit and it never came back down (until I restarted Calibre). This is a very tiny leak compared to the one(s) that used to suck memory. IMHO Very livable |
|
09-15-2012, 11:32 AM | #28 |
Grand Sorcerer
Posts: 11,693
Karma: 6240117
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
|
@theducks: there are several things that will "permanently" consume memory. Some are the tag browser data structures (the item tree), caches in devices, and the cover cache. There are a lot of others. These aren't "leaks" because the memory is kept on purpose and reused if/when the keeper chooses.
|
09-15-2012, 12:00 PM | #29 |
Addict
Posts: 254
Karma: 69786
Join Date: May 2006
Location: Oslo, Norway
Device: Kobo Aura, Sony PRS-650
|
And, at the end of the day this was a really trivial problem. It could be fixed at any time, in a few seconds, by simply hitting Ctrl+R. It's nice that this memory leak is fixed, but I hope the devs focus their time and energy on adding or improving functionality rather than hunting down these kinds of bugs.
Or, to put it this way: a great many people might be affected by some random issue that stops their workflow in some manner (like a new device which yet has no calibre plugin). There are very few people who have the competence and inclination to hack calibre effectively. What would you prefer them to do: help those people or add some nifty conversion feature, or hunt down very minor annoyances with trivial workarounds? Of course each developer chooses what they'd like to improve, but I know what I'd like them to focus on. |
09-15-2012, 12:09 PM | #30 | |
Well trained by Cats
Posts: 29,662
Karma: 54369090
Join Date: Aug 2009
Location: The Central Coast of California
Device: Kobo Libra2,Kobo Aura2v1, K4NT(Fixed: New Bat.), Galaxy Tab A
|
Quote:
|
|
Thread Tools | Search this Thread |
|
Similar Threads | ||||
Thread | Thread Starter | Forum | Replies | Last Post |
Memory usage | jessie102 | Calibre | 4 | 01-29-2015 12:44 PM |
Problems with Sony PRS-650, SD memory card. Is this the norm? | BetaPanther | Sony Reader | 9 | 10-20-2011 02:09 AM |
Sony PRS-650: Memory Cards are not recognized | IchBinIch | Calibre | 17 | 10-15-2010 01:53 PM |
Extreme memory usage | MJBoa | Calibre | 1 | 02-12-2010 11:37 AM |
Memory Usage | BCCISProf | Sony Reader | 15 | 05-16-2007 08:11 PM |