Find / Replace does not respect "down" setting

[DrChiper]

When I want to replace via Find/Replace some text from the current page cursor position "down" ("wrap" is not selected) towards the end of the e-book, the replace also sometimes takes place "above" the current cursor position and even in previous chapter files which precedes this page file. This is not what I expected (and wanted). The funny thing is that it does not always happens, making reproducing it hard.

The chapter files are properly sorted ascending in the spine, so that could not be the issue here.

Does anybody has seen this behavior also?
(I am using 1.21, but seen it in previous versions sometimes too)

[theducks]

Originally Posted by DrChiper

When I want to replace via Find/Replace some text from the current page cursor position "down" ("wrap" is not selected) towards the end of the e-book, the replace also sometimes takes place "above" the current cursor position and even in previous chapter files which precedes this page file. This is not what I expected (and wanted). The funny thing is that it does not always happens, making reproducing it hard.

The chapter files are properly sorted ascending in the spine, so that could not be the issue here.

Does anybody has seen this behavior also?
(I am using 1.21, but seen it in previous versions sometimes too)

Are you using: Selected files or some other ?
E-book editor does these choices slightly different from Sigil (I always got annoyed having to switch to Current when running replaces in the CSS)

[DrChiper]

Nope, just working my way down from cover page file to the bottom of the last page file with setting "all text files". It just happened to me today again on removing superfluous </span>'s. With big changes I always check. On this occasion I expected to see just 1 intentional </span> left in a previous chapter, but that was gone
So I decided to mention it here for the benefit of others.

I know that Edit-Book behaves differently than Sigil, but expected somehow similar behavior for F/R "downwards".

For the good order: I am now capable to do my touching-ups completely in Edit Book; no need to use Sigil anymore. That is a great plus (as always: thanks Kovid!)

[cybmole]

In sigil, "all files" overrules up / down choice. All means ALL
I woud expect same logic in calibre editor

[DrChiper]

Originally Posted by cybmole

In sigil, "all files" overrules up / down choice. All means ALL
I woud expect same logic in calibre editor

Just tested: but unfortunately you are mistaken. It starts from current current position to last file provided no wrap is selected when set with "all files". Hence, no overruling.

[theducks]

The behavior replace All changed, back and forth in later versions of Sigil.

Originally it honored the No wrap (and direction) and started from the current location.

I think it has returned to that behavior.

[DrChiper]

Well, never mind Sigil, the important question is: How is the behavior of Edit Book intended to be? At the moment I am replacing text which is not supposed to be replaced. What are the correct settings to avoid that?

[cybmole]

Originally Posted by theducks

The behavior replace All changed, back and forth in later versions of Sigil.

Originally it honored the No wrap (and direction) and started from the current location.

I think it has returned to that behavior.

I have sigil v7.2 I think it mostly it behaves for me as I described, when I use replace ALL. ( but I usually click it twice, just to be sure, sometimes the 2nd click finds more stuff to replace! )

I would vote for same logic in calibre , if it were a voting issue. It would be very strange for replace ALL not to operate on ALL files irrespective of up/down setting
but stepwise - replace+find-next - it could be argued either way, certainly the directional preference should apply but whether there should also be wraparound... shouldn't matter really if you are begin observant...

And it would be nice if both programs used the same rules, esp. wile I am still transitioning from one to the other

[theducks]

Originally Posted by cybmole

I have sigil v7.2 I think it mostly it behaves for me as I described, when I use replace ALL. ( but I usually click it twice, just to be sure, sometimes the 2nd click finds more stuff to replace! )

I would vote for same logic in calibre , if it were a voting issue. It would be very strange for replace ALL not to operate on ALL files irrespective of up/down setting
but stepwise - replace+find-next - it could be argued either way, certainly the directional preference should apply but whether there should also be wraparound... shouldn't matter really if you are begin observant...

And it would be nice if both programs used the same rules, esp. wile I am still transitioning from one to the other

I was one to vote to vote Replace All should respect the settings and the Start point.

Replace all in my context means don't ask (behaves like replace next was clicked every time). Replace from here to end.

[kovidgoyal]

Replace all replaces all in the set of files you have chosen, it does not consider direction or wrap at all. If you want to run replace all only a region of a particular file, select that region, mark it with Search->Mark selected text then run the replace all in "Marked text"

[DoctorOhh]

Originally Posted by kovidgoyal

Replace all replaces all in the set of files you have chosen

As it should be.

[DrChiper]

Originally Posted by DoctorOhh

As it should be.

I beg to differ, but that is a common mistake in software land. There is no good or wrong: it is just a design decision. So in my opinion it should read: as Kovid designed it to work. Whether you like that decision or not is another matter and a personal one too. Speaking for myself: as long as I know how it is supposed to work (and it actually does so ) there is never a problem.

So now that I have a clear vision on how it is supposed to work, maybe I can make a small suggestion:
Kovid is it not better to make it clear to the user that when the "all text files" (and all style files) option is selected, the options "wrap" and "down/up" have no meaning anymore by making them not selectable (=greyout) or even not visible? Then it is obvious that ALL really means ALL with no exceptions.

Just my 2cts to make a good application perhaps a little better.

[kovidgoyal]

They most definitely have a meaning, they are used when your click either find or replace/find. It is only replace all that ignores them.

[DrChiper]

So: "Find" or "Find/Replace" with option "all text files" will only find ALL occurrences when option "wrap" is set? In other words there is a difference in working between "Find" and "Replace"? I surely never expected that Hence, ALL is not always ALL it depends on what your are doing.

[kovidgoyal]

Find and replace/find do not find all matches, they find the *next* match and what is the next match very much depends on the search direction and wrapping, that is patently obvious.

Replace all replaces *all* matches, and the set of all matches does not depend on either direction or wrapping. That is also patently obvious.