07-14-2014, 04:40 PM | #2056 |
Ex-Helpdesk Junkie
Posts: 19,421
Karma: 85397180
Join Date: Nov 2012
Location: The Beaten Path, USA, Roundworld, This Side of Infinity
Device: Kindle Touch fw5.3.7 (Wifi only)
|
NiLuJe, are you updating this plugin for the qt5 betas?
Also, maybe this would be a good time to get KC a new thread owned by you to support both versions -- now that the old one needs to go anyway? Last edited by eschwartz; 07-15-2014 at 12:39 AM. Reason: typos |
07-14-2014, 06:34 PM | #2057 |
BLAM!
Posts: 13,480
Karma: 26012494
Join Date: Jun 2010
Location: Paris, France
Device: Kindle 2i, 3g, 4, 5w, PW, PW2, PW5; Kobo H2O, Forma, Elipsa, Sage, C2E
|
@eschwartz: That's certainly on the horizon, if Qt5 doesn't drive me mad in the process .
(And yeah, I agree that it would be a perfect opportunity to take maintainer-ship of the plugin) |
Advert | |
|
07-15-2014, 12:40 AM | #2058 |
Ex-Helpdesk Junkie
Posts: 19,421
Karma: 85397180
Join Date: Nov 2012
Location: The Beaten Path, USA, Roundworld, This Side of Infinity
Device: Kindle Touch fw5.3.7 (Wifi only)
|
|
07-15-2014, 01:36 AM | #2059 |
BLAM!
Posts: 13,480
Karma: 26012494
Join Date: Jun 2010
Location: Paris, France
Device: Kindle 2i, 3g, 4, 5w, PW, PW2, PW5; Kobo H2O, Forma, Elipsa, Sage, C2E
|
@eschwartz: Good to know, thanks .
(But the initial stages will probably consist of me making stuff up and hoping it works ;D). |
08-10-2014, 05:11 PM | #2060 |
Junior Member
Posts: 4
Karma: 10
Join Date: Aug 2014
Device: none
|
@NiLuJe porting to qt5 ist as easy as running search & replace on "PyQt4" -> "PyQt5".
I just did that and everything seems to be working perfectly so far If you take maintainership please upload this thing somewhere decent, like github or bitbucket. I don't really care where. That would just make contributing a lot easier. ~ Have a nice day |
Advert | |
|
08-10-2014, 05:15 PM | #2061 |
BLAM!
Posts: 13,480
Karma: 26012494
Join Date: Jun 2010
Location: Paris, France
Device: Kindle 2i, 3g, 4, 5w, PW, PW2, PW5; Kobo H2O, Forma, Elipsa, Sage, C2E
|
@6EQUJ5: Thanks, I'll probably do it in the coming week. (FWIW, I'm using SVN internally, so I'm good on the keeping track of stuff front ;p).
|
08-10-2014, 05:18 PM | #2062 |
Junior Member
Posts: 4
Karma: 10
Join Date: Aug 2014
Device: none
|
@NiLuJe doesn't help the community much :/
At least keeping track of stuff is always good |
08-10-2014, 05:23 PM | #2063 |
BLAM!
Posts: 13,480
Karma: 26012494
Join Date: Jun 2010
Location: Paris, France
Device: Kindle 2i, 3g, 4, 5w, PW, PW2, PW5; Kobo H2O, Forma, Elipsa, Sage, C2E
|
@6EQUJ5: Agreed, but on the other hand, you're the first one to show interest on that front in over a year . (Granted, there may also be a chicken/egg effect at play here ^^).
|
08-10-2014, 05:28 PM | #2064 |
Junior Member
Posts: 4
Karma: 10
Join Date: Aug 2014
Device: none
|
@NiLuJe: Well, this is the first time this plugin broke for me, so I just went ahead and fixed it :P
Then I was searching for where to send my changes, so other people can benefit. I don't plan to contribute to this project as in actively developing. It's just anywhere something breaks in my daily usage, I fix it myself (at least if I am able to) and push it back upstream. I guess it is not really necessary, but it would just ease things for people like me and the development is more transparent, which I am both a fan of :P |
08-10-2014, 05:51 PM | #2065 |
BLAM!
Posts: 13,480
Karma: 26012494
Join Date: Jun 2010
Location: Paris, France
Device: Kindle 2i, 3g, 4, 5w, PW, PW2, PW5; Kobo H2O, Forma, Elipsa, Sage, C2E
|
@6EQUJ5: We have a few projects like this on MR with very few activity where we usually fall back to posting patches in the project's thread .
|
08-10-2014, 06:09 PM | #2066 | |
Junior Member
Posts: 4
Karma: 10
Join Date: Aug 2014
Device: none
|
Quote:
The reason I didn't post a patch is that it's very easy to do and I just explained how it can be done :P meme, the creator of this plugin is inactive I understand? |
|
08-10-2014, 06:10 PM | #2067 |
BLAM!
Posts: 13,480
Karma: 26012494
Join Date: Jun 2010
Location: Paris, France
Device: Kindle 2i, 3g, 4, 5w, PW, PW2, PW5; Kobo H2O, Forma, Elipsa, Sage, C2E
|
@6EQUJ5: Yeah, no worry, that's good enough for me, that was just to give you some context as to why I never bothered making the repo more widely accessible .
And yeah, meme is inactive; I'll probably ask for maintener-ship more properly with the Qt5 switch, that'll be easier on everyone. |
08-10-2014, 06:15 PM | #2068 |
Ex-Helpdesk Junkie
Posts: 19,421
Karma: 85397180
Join Date: Nov 2012
Location: The Beaten Path, USA, Roundworld, This Side of Infinity
Device: Kindle Touch fw5.3.7 (Wifi only)
|
I've ported the imports over to Qt5 as per Kovid's sticky, and reloaded the plugin. It seems to be working just fine. Nothing else needed.
(Extra confirmation. ) Last edited by eschwartz; 08-10-2014 at 06:19 PM. |
08-10-2014, 07:02 PM | #2069 |
BLAM!
Posts: 13,480
Karma: 26012494
Join Date: Jun 2010
Location: Paris, France
Device: Kindle 2i, 3g, 4, 5w, PW, PW2, PW5; Kobo H2O, Forma, Elipsa, Sage, C2E
|
@eschwartz: The most UI-heavy thing is the manual collection edit screen, so if that works, everything should be good .
|
08-10-2014, 08:15 PM | #2070 |
BLAM!
Posts: 13,480
Karma: 26012494
Join Date: Jun 2010
Location: Paris, France
Device: Kindle 2i, 3g, 4, 5w, PW, PW2, PW5; Kobo H2O, Forma, Elipsa, Sage, C2E
|
I ported the tweaked version.
Only tested on PyQt4 so far, but the only tricky thing different from the upstream version was a QVariant that needed to be taken care of, and the potential issues are mostly on the PyQt4 side with this. |
|
Similar Threads | ||||
Thread | Thread Starter | Forum | Replies | Last Post |
[GUI Plugin] Kindle Collections (Update) | NiLuJe | Plugins | 463 | 02-16-2024 12:43 AM |
Kindle Collections plugin | JosephWebber | Plugins | 1 | 08-21-2017 11:44 AM |
[GUI Plugin] WebOS Kindle-Import | CranstD | Plugins | 0 | 01-24-2012 03:36 PM |
Finding and using Kindle Collections Plugin | djchapple | Plugins | 2 | 08-03-2011 10:06 AM |
[GUI Plugin] Plugin Updater **Deprecated** | kiwidude | Plugins | 159 | 06-19-2011 12:27 PM |