Register Guidelines E-Books Search Today's Posts Mark Forums Read

Go Back   MobileRead Forums > E-Book Software > Calibre > Development

Notices

Reply
 
Thread Tools Search this Thread
Old 12-29-2012, 10:53 AM   #1
John Peterson
Member
John Peterson began at the beginning.
 
Posts: 21
Karma: 10
Join Date: Jul 2011
Device: none
GitHub mirror

There's a mirror at https://github.com/mirror/calibre for users that prefer GitHub (originally mentioned at https://bugs.launchpad.net/calibre/+bug/1093634).

The mirror has pull requests that it would be beneficial to discuss within a reasonable time because the possibility of merge conflicts increase with time.

The pull requests can be applied with

*`bzr git-apply`
* or by asking me to upload to launchpad with `git bzr push`

Last edited by John Peterson; 02-01-2013 at 03:49 PM.
John Peterson is offline   Reply With Quote
Old 12-29-2012, 07:48 PM   #2
hakan42
Zealot
hakan42 is on a distinguished road
 
hakan42's Avatar
 
Posts: 136
Karma: 60
Join Date: Jul 2009
Location: Munich, Germany
Device: Nook Classic rooted; Galaxy S IV with Aldiko, other older devices
Quote:
Originally Posted by mr500 View Post
There's a mirror at https://github.com/mirror/calibre for users that prefer GitHub (originally mentioned at https://bugs.launchpad.net/calibre/+bug/1093634).

The mirror has pull requests (applied with `bzr git-apply`).
Thank you, thank you, thank you so very much
hakan42 is offline   Reply With Quote
Old 01-05-2013, 02:24 PM   #3
John Peterson
Member
John Peterson began at the beginning.
 
Posts: 21
Karma: 10
Join Date: Jul 2011
Device: none
I want to bring attention to this message

> The mirror has pull requests (can be applied with `bzr git-apply`) that it would be beneficial to discuss within a reasonable time

Last edited by John Peterson; 01-05-2013 at 07:32 PM.
John Peterson is offline   Reply With Quote
Old 01-05-2013, 02:32 PM   #4
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 26,131
Karma: 5381911
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
If you want me to consider a merge request you need to submit it via Launchpad. You are welcome to use github for your own development if you prefer it, but *I* am not going to look at merge requests in two places. Using a projects' established version control procedures when you want your code accepted in that project is basic courtesy. To reiterate something I have stated in many places, I accept patches in the following forms:

1) Launchpad merge requests
2) Bazaar merge requests generated by bzr send and emailed to me or attached to a bug report
3) Plain patches emailed to me or attached to a bug report
kovidgoyal is offline   Reply With Quote
Old 01-05-2013, 02:43 PM   #5
John Peterson
Member
John Peterson began at the beginning.
 
Posts: 21
Karma: 10
Join Date: Jul 2011
Device: none
> I am not going to look at merge requests in two places

Why?

Last edited by John Peterson; 01-05-2013 at 05:05 PM.
John Peterson is offline   Reply With Quote
Old 01-05-2013, 02:54 PM   #6
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 26,131
Karma: 5381911
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
Because.
kovidgoyal is offline   Reply With Quote
Old 01-05-2013, 03:43 PM   #7
John Peterson
Member
John Peterson began at the beginning.
 
Posts: 21
Karma: 10
Join Date: Jul 2011
Device: none
Requesting adequate reply

I request an adequate reply to this post as defined and advocated by the article efficient communication.

Requesting option to discuss patches at GitHub

I argue that

* there's no significant disadvantage or inconvenience with discussing a patch on GitHub compared to Launchpad
* manual monitoring is not necessary because there's a `Watch`option to receive mail notifications
* there's no significant disadvantage or inconvenience in applying a patch from GitHub because
** it can without significant effort be applied with `bzr git-apply` (and retrieved from a .patch suffix to the commit URL)
** if asked the author can upload to launchpad with `git bzr push`
* GitHub is popular and it's therefore within reasonable flexibility to allow discussion there
* Allowing code discussion on GitHub too encourage competition between the sites which is beneficial
* Allowing patch discussion on GitHub might bring more ideas and coding effort to the project because some users prefer to discuss patches there

GitHub advantage

I argue that some users see these differences as a significant disadvantage or inconvenience in discussing a patch on Launchpad compared to GitHub

* GitHub allow message editing to correct errors in spelling, clarity, or logic, and therefore doesn't force the user to accept the dissatisfaction of leaving such errors permanent (and other arguments in the Launchpad discussion about message editing)
* git is more efficient than bzr for patch discussion, primarily when (i) rebasing with commands such as `git commit --amend`, `git reset --soft HEAD^`, `git rebase -i` and (ii) diff editing because TortoiseGit's `TortoiseMerge.exe` allow editing (to easily fix accidental white space or remove temporary logging before commit) which bzr's `tbzrcommand.exe --command=diff` doesn't
* GitHub allow message markup which allow clearer messages
* Launchpad send notification for a change to the user that did the change which is an annoyance

Clarification

Prompted by discussion below I want to clarify that I'm not asking for anything more than

> discussing a patch on GitHub

I'm not asking for f.e.

* applying the patch from Github (with `bzr git-apply`) if there's an objection to that because if asked I can instead upload it to launchpad with `git bzr push`
* mirroring to GitHub
* moving to GitHub

If there's a concern that the patch base is outdated the committer can (instead of applying the patch from GitHub with `bzr git-apply`)

* ask the author to upload the patch to launchpad with `git bzr push`

(If there's an opinion in this thread that I've not replied to it might be because I found it unclear, similar to another argument, or non-meaningful.)

Last edited by John Peterson; 02-01-2013 at 04:04 PM.
John Peterson is offline   Reply With Quote
Old 01-05-2013, 09:10 PM   #8
theducks
Grand Sorcerer
theducks ought to be getting tired of karma fortunes by now.theducks ought to be getting tired of karma fortunes by now.theducks ought to be getting tired of karma fortunes by now.theducks ought to be getting tired of karma fortunes by now.theducks ought to be getting tired of karma fortunes by now.theducks ought to be getting tired of karma fortunes by now.theducks ought to be getting tired of karma fortunes by now.theducks ought to be getting tired of karma fortunes by now.theducks ought to be getting tired of karma fortunes by now.theducks ought to be getting tired of karma fortunes by now.theducks ought to be getting tired of karma fortunes by now.
 
theducks's Avatar
 
Posts: 14,869
Karma: 5654321
Join Date: Aug 2009
Location: (The original) Silicon Valley, USA
Device: Galaxy Tab 2, Astak Pocket Pro, K4NT
John
Calibre is Kovid's project.

If he wants to use Launchpad, that is his choice. Just like it may be your choice NOT to contribute because you don't like his choice.

Offering up a newish alternate was fine.
It has been rejected.. He does not have to give anyone reasons.

It is a PITA to work from 2 streams. I don't find any fault with rejecting that choice.
We all have our favorite tools. You have been given submission alternates. Having lots of active developers is , but they must follow the leader to be successful.
theducks is offline   Reply With Quote
Old 01-15-2013, 03:58 PM   #9
John Peterson
Member
John Peterson began at the beginning.
 
Posts: 21
Karma: 10
Join Date: Jul 2011
Device: none
I want to bring attention to the arguments in my previous post in this thread.

Last edited by John Peterson; 02-01-2013 at 03:59 PM.
John Peterson is offline   Reply With Quote
Old 01-15-2013, 05:34 PM   #10
kiwidude
calibre/Sigil Developer
kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.
 
Posts: 4,228
Karma: 1334002
Join Date: Oct 2010
Location: London, UK
Device: Kindle Paperwhite 3G, iPad 3, iPad Air
So what? There will always be advantages and disadvantages combined with personal preferences of one source control system over another. What preferences you personally have bear absolutely no relevance, as the ducks says it is up to Kovid who works full time on this project to decide where he wants to host it. Now if you can convince him to *move* the calibre source to GitHub that is one thing, but to setup your own mirror and then complain about Kovid quite rightly choosing not to have anything to do with it is utterly ridiculous.

I really don't understand your attitude with this. It would be utter insanity for Kovid to add to his workload to attempt to mirror onto multiple source control systems, it isn't even worth a minute of consideration. From his posts above he doesn't appear to be motivated to move, and frankly if that is the case I don't blame him - he and the many other contributors to calibre have years of experience with his existing setup and numerous scripts etc, so to stall development and put everyone through the upheaval of learning git is not a decision to be taken lightly.
kiwidude is offline   Reply With Quote
Old 01-15-2013, 05:40 PM   #11
John Peterson
Member
John Peterson began at the beginning.
 
Posts: 21
Karma: 10
Join Date: Jul 2011
Device: none
This message seem to have misunderstood my request and I've therefore posted a clarification under the topic "Clarification" in the message above.
John Peterson is offline   Reply With Quote
Old 01-15-2013, 05:59 PM   #12
kiwidude
calibre/Sigil Developer
kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.
 
Posts: 4,228
Karma: 1334002
Join Date: Oct 2010
Location: London, UK
Device: Kindle Paperwhite 3G, iPad 3, iPad Air
But how can you differentiate the two? A patch is generated based on differences against a base. As Kovid isn't managing your mirror, he has zero control or knowledge of what "base" the patch is generated against. For all he knows that patch is generated for code that was mirrored three months ago and no longer applies. At least when the contributor is on the same source control system they can be sure to easily sync to the main development trunk before generating their patch, or branch with confidence from it.

Also for major contributors they tend to work on a branch which Kovid merges in, which isn't an option when on another source system.

Last edited by kiwidude; 01-15-2013 at 06:01 PM.
kiwidude is offline   Reply With Quote
Old 01-15-2013, 06:13 PM   #13
John Peterson
Member
John Peterson began at the beginning.
 
Posts: 21
Karma: 10
Join Date: Jul 2011
Device: none
I've posted a discussion about this to the topic "Clarification" above.
John Peterson is offline   Reply With Quote
Old 01-15-2013, 06:51 PM   #14
user_none
Sigil & calibre developer
user_none ought to be getting tired of karma fortunes by now.user_none ought to be getting tired of karma fortunes by now.user_none ought to be getting tired of karma fortunes by now.user_none ought to be getting tired of karma fortunes by now.user_none ought to be getting tired of karma fortunes by now.user_none ought to be getting tired of karma fortunes by now.user_none ought to be getting tired of karma fortunes by now.user_none ought to be getting tired of karma fortunes by now.user_none ought to be getting tired of karma fortunes by now.user_none ought to be getting tired of karma fortunes by now.user_none ought to be getting tired of karma fortunes by now.
 
user_none's Avatar
 
Posts: 2,460
Karma: 986493
Join Date: Jan 2009
Location: Florida, USA
Device: Nook STR
Quote:
Originally Posted by John Peterson View Post
I want to bring attention to this message
> * there's no significant disadvantage or inconvenience with discussing a patch on GitHub compared to Launchpad
* there's no significant disadvantage or inconvenience with discussing a patch on Launchpad compared to GitHub.

Quote:
Originally Posted by John Peterson View Post
> * there's no significant disadvantage or inconvenience in applying a patch from GitHub bcause the patch is retrieved from a .patch suffix to the commit URL and can be applied with `bzr git-apply`
* there's no significant disadvantage or inconvenience in submitting a patch via Launchpad.

Quote:
Originally Posted by John Peterson View Post
> * GitHub is popular and it's therefore within reasonable flexibility to allow discussion there
* Launchpad is popular and it's therefore within reasonable flexibility to use it.

Quote:
Originally Posted by John Peterson View Post
> * Allowing code discussion on GitHub too encourage competition between the sites which is beneficial
* Allowing code discussion on Launchpad encourages collaboration on calibre which is beneficial. Competition between two hosting services isn't the goal of calibre and outside of calibre's scope.

Quote:
Originally Posted by John Peterson View Post
* Allowing patch discussion on GitHub might bring more ideas and coding effort to the project because some users prefer to discuss patches there
Let's see you're willing to use Launchpad simply because you don't want to even though that's what calibre uses and what every calibre developer uses. This tells me two things. 1) You're not able to take any level of criticism because you won't make even the slightest attempt to work within calibre's development guidelines. 2) You're contributions no matter how brilliant are going to be more trouble then they're worth.
user_none is offline   Reply With Quote
Old 01-15-2013, 06:56 PM   #15
kiwidude
calibre/Sigil Developer
kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.
 
Posts: 4,228
Karma: 1334002
Join Date: Oct 2010
Location: London, UK
Device: Kindle Paperwhite 3G, iPad 3, iPad Air
But all this does is create extra work for Kovid for absolute zero benefit. Why should Kovid have to waste his time trying to reconcile patch dates or request mirror updates?

A user who wants to genuinely contribute to calibre will do whatever they need to do with the existing infrastructure, as I and dozens of other contributors have done. Adding to Kovid's workload in any shape or form just because user x wants to use Git over Bazaar is just plain silly. As I said above, either you request and get Kovid to agree to move calibre onto Git, or you suck it up and use what exists and works perfectly fine as is.

Splitting a project across two source control systems is pretty much unprecedented in the development community AFAIK for a long list of very good reasons. But anyways that's my rant on the subject over, I'm done.
kiwidude is offline   Reply With Quote
Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
daily mirror uk update 12/10/12 scissors Recipes 2 10-19-2012 09:57 AM
Mirror a Library leehach Library Management 1 09-01-2011 05:00 AM
Downloading source repository from github fails. Ideas? Cyberman tM Kobo Reader 0 05-29-2011 02:17 PM
Zen and the Man in the Mirror Barcey News 3 02-08-2010 11:51 AM
Two Way Mirror B.K. Wright Writers' Corner 0 11-01-2009 11:26 AM


All times are GMT -4. The time now is 03:46 PM.


MobileRead.com is a privately owned, operated and funded community.