closing tags not auto-fixing

cybmole · 12-03-2012, 07:44 AM

i am seeing different behaviours in 6.01 from 6.0

if I replace all
<p class= whatever
with <h2 class=whatever
across all files

then sigil no longer applies matching closing tags , instead it gives me tag errors to fix

all I did was install over 6.0 I did not alter any other preferences.

upate: i reinstalled 6.0 , tried same operation on same book - the same regex now works ok - closing tags are fixed as I want them to be, automatically

kiwidude · 12-03-2012, 09:13 AM

You have to change your Preferences ->Clean Source options from "Pretty Print" to "Pretty Print Tidy" (which is the functional equivalent of what you had in 0.6). Users upgrading from 0.6 have to manually do this.

cybmole · 12-03-2012, 10:56 AM

i thought it may be something like that,
perhaps add a warning to release notes re need to manually adjust ?

user_none · 12-03-2012, 07:01 PM

Quote:

Originally Posted by kiwidude

Users upgrading from 0.6 have to manually do this.

Hm... They shouldn't have too. The value should have been the same...

phossler · 12-03-2012, 10:15 PM

FWIW -- I tried all 4 appearance options -- just replacing <i> with nothing, and I can't the 6.0 behaviour either

The 4 options all left the </i>

Code:

<?xml version="1.0" encoding="utf-8" standalone="no"?>
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN"
  "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd">
 
<html xmlns="http://www.w3.org/1999/xhtml">
<head>
  <title></title>
</head>
 
<body>
  <p>xxxxxxxxxxxxxxxxxxx</p>
 
  <p>xxxxxxxxxxxxxxxxxxxxxxxxxxx</p>
 
  <p>xxxx used to have the opening tag xxxxxxxxx</i></p>
</body>
</html>

[Fix Automatically] does, after I read the warning I don't like to use it if it's just one or two things

Paul

cybmole · 12-04-2012, 01:45 AM

Quote:

Originally Posted by user_none

Hm... They shouldn't have too. The value should have been the same...

I think I just proved otherwise

. this is with the 64bit windows build

PS I re-installed 6.01, changed that preference, re-tested - it is OK after the manual change

kiwidude · 12-04-2012, 03:50 AM

Quote:

Originally Posted by user_none

Hm... They shouldn't have too. The value should have been the same...

No, the config file value stored for "Pretty Print" in 0.6 is what you used for "Pretty Print" in 0.6.1, rather than for the equivalent of "Pretty Print Tidy". I did mention this in an email ages ago, and in response I think you changed the default value for new users (with no sigil.ini) to be Pretty Print Tidy rather than changing the mapping of the config file value.

I have verified this btw, if you have both 0.6 and 0.6.1, start up 0.6, make sure it is set to "Pretty Print", exit and start 0.6.1 and it stays at "Pretty Print".

WS64 · 12-04-2012, 04:07 AM

Quote:

Originally Posted by cybmole

I think I just proved otherwise

. this is with the 64bit windows build

Same here (Windwos version and behaviour).
Had to change it manually.

phossler · 12-04-2012, 08:49 AM

Quote:

FWIW -- I tried all 4 appearance options -- just replacing <i> with nothing, and I can't the 6.0 behaviour either

Hmmm - do I set something else to get the closing tag 'fixed'?

Paul

12-03-2012, 07:44 AM	#1
cybmole Wizard Posts: 1,686 Karma: 772746 Join Date: Sep 2010 Device: Sony PRS 650, Kindle for PC	closing tags not auto-fixing i am seeing different behaviours in 6.01 from 6.0 if I replace all <p class= whatever with <h2 class=whatever across all files then sigil no longer applies matching closing tags , instead it gives me tag errors to fix all I did was install over 6.0 I did not alter any other preferences. upate: i reinstalled 6.0 , tried same operation on same book - the same regex now works ok - closing tags are fixed as I want them to be, automatically Last edited by cybmole; 12-03-2012 at 07:57 AM.

12-03-2012, 09:13 AM	#2
kiwidude calibre/Sigil Developer Posts: 4,087 Karma: 1211084 Join Date: Oct 2010 Location: London, UK Device: Kindle 3 3G, iPad 2, iPad 3	You have to change your Preferences ->Clean Source options from "Pretty Print" to "Pretty Print Tidy" (which is the functional equivalent of what you had in 0.6). Users upgrading from 0.6 have to manually do this. __________________ Like my calibre plugins or Sigil work? Say thanks with PayPal

12-03-2012, 10:15 PM	#5
phossler Connoisseur Posts: 82 Karma: 10 Join Date: Jan 2009 Location: Valley Forge, PA, USA Device: kindle	FWIW -- I tried all 4 appearance options -- just replacing <i> with nothing, and I can't the 6.0 behaviour either The 4 options all left the </i> Code: <?xml version="1.0" encoding="utf-8" standalone="no"?> <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.1//EN" "http://www.w3.org/TR/xhtml11/DTD/xhtml11.dtd"> <html xmlns="http://www.w3.org/1999/xhtml"> <head> <title></title> </head> <body> <p>xxxxxxxxxxxxxxxxxxx</p> <p>xxxxxxxxxxxxxxxxxxxxxxxxxxx</p> <p>xxxx used to have the opening tag xxxxxxxxx</i></p> </body> </html> [Fix Automatically] does, after I read the warning I don't like to use it if it's just one or two things Paul Last edited by phossler; 12-03-2012 at 10:17 PM.

Thread Tools	Search this Thread
Show Printable Version Email this Page	Search this Thread: Advanced Search

Similar Threads
Thread	Thread Starter	Forum	Replies	Last Post
questions on self-closing tags and legal xhtml in epubs	KevinH	ePub	5	04-23-2012 10:12 PM
Help with EPUb validation and closing tags	book24	ePub	1	05-24-2011 05:16 PM
Release 0.7.54 - Mobi self-closing tags	Moonraker	Calibre	2	04-09-2011 07:35 AM
find replace - does it auto-fix closing tqags ???	cybmole	Sigil	6	01-19-2011 02:32 PM
Auto sort tags?	scottjl	Calibre	2	12-19-2009 11:56 AM

12-03-2012, 10:56 AM	#3
cybmole Wizard Posts: 1,686 Karma: 772746 Join Date: Sep 2010 Device: Sony PRS 650, Kindle for PC	i thought it may be something like that, perhaps add a warning to release notes re need to manually adjust ?


Advertisement Enthusiast