[GUI Plugin] Open With

[kiwidude]

@user_none - thanks for taking a look into this again. I tried to just make the changes you suggested, but I don't have a linux box to test it on myself.

@kovid - the problem with open_local_file is that it seems to take just a single filepath as the argument. Whereas I need to launch an app supplying additional arguments. Hence the plugin currently uses subprocess.Popen()

[kovidgoyal]

Ah right, then you should duplicate the LD_LIBRARY_PATH logic in open_url()

[user_none]

The latest version is working in my Ubuntu 11.04 VM. Can someone who's having a problem on Linux try it with calibre-debug -g and post the console output if it shows anything interesting?

[theducks]

Originally Posted by user_none

The latest version is working in my Ubuntu 11.04 VM. Can someone who's having a problem on Linux try it with calibre-debug -g and post the console output if it shows anything interesting?

Here you go
I hit Alt-E a few times, no joy

calibre Debug log
calibre 0.8.16
Linux-2.6.38-11-generic-i686-with-debian-squeeze-sid
Linux
('Linux', '2.6.38-11-generic', '#48-Ubuntu SMP Fri Jul 29 19:05:14 UTC 2011')
Python 2.7.1
Linux: ('debian', 'squeeze/sid', '')
Starting up...
Started up in 16.5851202011

[user_none]

Originally Posted by theducks

Here you go
I hit Alt-E a few times, no joy

calibre Debug log
calibre 0.8.16
Linux-2.6.38-11-generic-i686-with-debian-squeeze-sid
Linux
('Linux', '2.6.38-11-generic', '#48-Ubuntu SMP Fri Jul 29 19:05:14 UTC 2011')
Python 2.7.1
Linux: ('debian', 'squeeze/sid', '')
Starting up...
Started up in 16.5851202011

Nothing there. Can you try selecting the Sigil menu item directly and see if that give some type of output? If it was failing it should be showing an error message.

[theducks]

Originally Posted by user_none

Nothing there. Can you try selecting the Sigil menu item directly and see if that give some type of output? If it was failing it should be showing an error message.

Directly? from the command prompt?

[user_none]

Originally Posted by theducks

Directly? from the command prompt?

I mean use the drop down arrow next to "Open With" in the tool bar. Then select the Sigil entry. This will ensure the Sigil item is run. I'm hoping there is something with your setup that Sigil isn't the default action or a shortcut conflict with the new shortcut code added recently.

[theducks]

Originally Posted by user_none

I mean use the drop down arrow next to "Open With" in the tool bar. Then select the Sigil entry. This will ensure the Sigil item is run. I'm hoping there is something with your setup that Sigil isn't the default action or a shortcut conflict with the new shortcut code added recently.

That way works.

BTW when I set the 'Custom' keystroke for Open With : for Sigil entry, the entry appears like a pause button instead of saying Alt-E

[mightymouse2045]

Originally Posted by user_none

I mean use the drop down arrow next to "Open With" in the tool bar. Then select the Sigil entry. This will ensure the Sigil item is run. I'm hoping there is something with your setup that Sigil isn't the default action or a shortcut conflict with the new shortcut code added recently.

Lol yeah I can confirm that in Fedora 15 it works also by adding the open with to the toolbar and selecting sigil that way.

Just when right clicking and selecting 'open with/sigil' doesn't work

[DoctorOhh]

Originally Posted by mightymouse2045

Lol yeah I can confirm that in Fedora 15 it works also by adding the open with to the toolbar and selecting sigil that way.

Just when right clicking and selecting 'open with/sigil' doesn't work

Whether you click from the toolbar or right click and select open with in the context menu the same code is used to open Sigil. User_none was pointing out that using a shortcut might not be working yet as there may be a conflict between the new calibre shortcut customization and the customizable shortcuts in the plugin itself.

[mightymouse2045]

Originally Posted by mightymouse2045

Lol yeah I can confirm that in Fedora 15 it works also by adding the open with to the toolbar and selecting sigil that way.

Just when right clicking and selecting 'open with/sigil' doesn't work

How strange I tested this yesterday and it wasn't working at all, now after a reboot and when I added it to the toolbar (it was only enabled in the context menu previously) it is working both by right clicking and from the toolbar.

I don't know if it was just the reboot but it's working... I even deleted my calibre config and all plugins and retried just adding it in the context menu only to see if that was it - but it worked straight away?!?

Anyways it seems to be fixed now - so thanks very much guys for your assistance with this

Cheers

[kiwidude]

Right - so everyone is working ok now, apart from possibly the keyboard shortcuts? (which incidentally work fine for me on Windows 7 at least). The shortcuts will hopefully be sorted for the next release once I figure out exactly how I am going to work with the new API around those.

Also kpw kindly informed me that the path to Sigil (default path for first time users of this plugin) was cased incorrectly with Sigil.sh instead of sigil.sh so that wil be changed for the next release.

[theducks]

Originally Posted by kiwidude

Right - so everyone is working ok now, apart from possibly the keyboard shortcuts? (which incidentally work fine for me on Windows 7 at least). The shortcuts will hopefully be sorted for the next release once I figure out exactly how I am going to work with the new API around those.

Also kpw kindly informed me that the path to Sigil (default path for first time users of this plugin) was cased incorrectly with Sigil.sh instead of sigil.sh so that wil be changed for the next release.

Keystrokes (short cuts) work on XP (Haven't booted the W7 laptop in weeks)

[carmenchu]

Kiwidude,
Everything last version, I have tried to save settings and got this:

Spoiler:

calibre, version 0.8.17
ERROR: Unhandled exception: <b>TypeError</b>:export_menus() takes exactly 1 argument (3 given)

TypeError: export_menus() takes exactly 1 argument (3 given)

I suspect it has to do with the new (don't how much, haven't added anything for ages) "Search the Internet"-like layout.

Now, the suggestions (see the "compare ePub thread" in Ideas for plugins:

Open_with with two paths for 7-zip/WinMerge, paths being:
- 2 compatible formats for selected book (i.e., PG zip html download/manybooks ePub: which should I convert from...?)
- 2 selected books (i.e., from Find Duplicates)
- selected book and clipboard (ticklish, needs some utility to capture whole Windows path to clipboard).

What about it?

[kiwidude]

@carmenchu - thx for the bug report, I will make sure it is fixed for the next version. I suspect it has been broken for a long time. Both the Import and Export menu options will throw that error.

As for your suggestion, I'm afraid I don't really see it happening in this plugin. It is too bespoke to a specific purpose, and requires inputs that don't match those that Open With works with.