The code does not handle apostrophes properly. Try a book like "spider's revenge" and click "link to goodreads". It will come up as not found. This is because the url is encoded twice in search strings, first with calls to quote_plus, and then to QUrl. The (very simple) fix is to call QUrl.fromEncoded(url) instead of QUrl(url) in a couple of places, and also modify a regexp that strips single quotes from book titles, causing additional search failures.
I've debugged it, and the patch against the latest version that is online is attached (as a txt file since .patch is not an allowed extension). If there is a better way to submit fixes, let me know.
|