MobileRead Forums - View Single Post - QtFrotz - Frotz port to Kobo e-readers

traycold · 12-17-2013, 05:26 AM

hi BigBoot,
thank you very much for your effort.
Maybe I found a small bug in the interpreter, i.e.: the abbreviation 'x' (for 'examine') doesn't work.
Having a look at source code, maybe the cause lies in this piece that handles some abbreviations (file: frotz/text.c):

Code:

[..]
    if (f_setup.expand_abbreviations)

	if (padding == 0x05 && decoded[1] == 0)

	    switch (decoded[0]) {
		case 'g': ptr = again; break;
		case 'x': ptr = examine; break;
		case 'z': ptr = wait; break;
	    }
[..]

Since the keyboard forces uppercase, I think the case statements should be switched to uppercase too, to force the 3 abbreviations handled here.

I don't have a development environment, so I can't recompile and verify by myself.

12-17-2013, 05:26 AM	#8
traycold Connoisseur Posts: 63 Karma: 196 Join Date: Oct 2010 Device: Kobo Glo Hd, Kobo H2O2	hi BigBoot, thank you very much for your effort. Maybe I found a small bug in the interpreter, i.e.: the abbreviation 'x' (for 'examine') doesn't work. Having a look at source code, maybe the cause lies in this piece that handles some abbreviations (file: frotz/text.c): Code: [..] if (f_setup.expand_abbreviations) if (padding == 0x05 && decoded[1] == 0) switch (decoded[0]) { case 'g': ptr = again; break; case 'x': ptr = examine; break; case 'z': ptr = wait; break; } [..] Since the keyboard forces uppercase, I think the case statements should be switched to uppercase too, to force the 3 abbreviations handled here. I don't have a development environment, so I can't recompile and verify by myself.