View Single Post
Old 12-25-2011, 10:56 PM   #10
kovidgoyal
creator of calibre
kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.kovidgoyal ought to be getting tired of karma fortunes by now.
 
kovidgoyal's Avatar
 
Posts: 43,869
Karma: 22666666
Join Date: Oct 2006
Location: Mumbai, India
Device: Various
Your change is not a "correct" fix. What it does is not show the extension being added. The dialog is supposed to show the extension being added, and it works on Windows, OS X, KDE. Furthermore it is the correct was to use QFileDialog as per the official Qt documentation: http://developer.qt.nokia.com/doc/qt...iledialog.html

Only some GNOME themes have problems with it, the fix needs to happen in them. Not showing the extensions reduces usability of the dialog.
kovidgoyal is offline   Reply With Quote