View Single Post
Old 07-09-2014, 12:30 PM   #47
chaley
Grand Sorcerer
chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.chaley ought to be getting tired of karma fortunes by now.
 
Posts: 11,742
Karma: 6997045
Join Date: Jan 2010
Location: Notts, England
Device: Kobo Libra 2
Quote:
Originally Posted by davidfor View Post
Hmm, there is something wrong with column icons when running from source. With the beta it is OK.

I have a five icon rules. Each returns a different icon to be put in the same column. What looks like is happening is if the first rule returns the icon, five copies of it are put into the column. And if the first rule doesn't return the an icon, then no icons are displayed no matter what the others return.

This is happening whether simple or advanced rules are used. There are no errors being displayed anywhere.

I think the above is correct. I'll have a bit more of a play tomorrow to see if there is more to it.
A few days ago I made a change to icon templates to use compiled templates. It is possible that I broke things when I did that. To test, could you change gui2/library/models.py line 96/97 to be:
Code:
rule_icons = self.formatter.safe_format(fmt, self.mi, '', self.mi)
The change is to remove the two named parameters column_name and template_cache.

Let me know if this fixes it, because if it does I must remove the changes before Friday's release.
chaley is offline   Reply With Quote