View Single Post
Old 04-14-2013, 10:23 PM   #51
DoctorOhh
US Navy, Retired
DoctorOhh ought to be getting tired of karma fortunes by now.DoctorOhh ought to be getting tired of karma fortunes by now.DoctorOhh ought to be getting tired of karma fortunes by now.DoctorOhh ought to be getting tired of karma fortunes by now.DoctorOhh ought to be getting tired of karma fortunes by now.DoctorOhh ought to be getting tired of karma fortunes by now.DoctorOhh ought to be getting tired of karma fortunes by now.DoctorOhh ought to be getting tired of karma fortunes by now.DoctorOhh ought to be getting tired of karma fortunes by now.DoctorOhh ought to be getting tired of karma fortunes by now.DoctorOhh ought to be getting tired of karma fortunes by now.
 
DoctorOhh's Avatar
 
Posts: 8,838
Karma: 12535517
Join Date: Feb 2009
Location: North Carolina
Device: Nexus 7
Quote:
Originally Posted by Kirtai View Post
I'd suggest copying the string to preserve the principle of least surprise. Changing something in one part of calibre shouldn't change or break things in a seemingly unconnected part.
I agree, copying the underlying search string is the way to go. If you don't do that then weeks or months later when a user decides to alter or clean up their saved searches they can easily break the VL which as you say is a "seemingly unconnected part."

Quote:
Originally Posted by Kirtai View Post
Also, you want to change the search and VL separately. e.g. start a VL with a saved search then tweak it.
Agreed, you should be able to tweak one without effecting the other.
DoctorOhh is online now   Reply With Quote