View Single Post
Old 03-26-2013, 05:25 PM   #18
JimmXinu
Plugin Developer
JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.JimmXinu ought to be getting tired of karma fortunes by now.
 
JimmXinu's Avatar
 
Posts: 6,584
Karma: 4277523
Join Date: Dec 2011
Location: Midwest USA
Device: Kindle Paperwhite(10th)
Hi, a few issues to know/consider:

The file kpp-american-english-dictionary-797865-words-list.oxt wouldn't load in the plugin for me. Debug output would show "Starting oxt workflow: C:\Users\<user>\Downloads\kpp-american-english-dictionary-797865-words-list.oxt" but that's it. PI v0.0.4, Calibre 0.9.24[64bit] on Win7. kpp-canadian-english-dictionary-674277-word-list.oxt did load and shows up as "eng.dic - English".

The Index of plugins thread is still showing v0.0.3 for this plugin instead of v0.0.4.

Internally, I see that you're using threads to run the background jobs instead of full processes. I did something very similar when I first wrote FFDL and I was advised by more experienced plugin developers that the way I was handling background processing was not particularly safe and I should use background process jobs instead. That was Jan 05, 2012 on calibre 0.8.33. I don't have the PMs anymore, but I think it was kiwidude telling me that, and that it had to do with memory leaks. It might be worth asking around.

For anyone else trying this out--if you Tweak the output and just look at the html files in Firefox's view page source, the added conditional hyphen characters don't show up. But they are there when viewed in a suitable editor.

Nook hyphenation is still (sometimes) broken. This is a Nook bug--nothing to do with this plugin--but I'd hoped that explicit soft hyphens would work around it. Applying style "adobe-hyphenate: none;" prevents the soft hyphens from being honored. Without that (or with "adobe-hyphenate: explicit;"), it does use the soft hyphens instead of it's own placement, but hyphenation is still broken--the ends of hyphenated words are sometimes not shown.
JimmXinu is offline   Reply With Quote