View Single Post
Old 07-07-2011, 05:21 PM   #32
hakan42
Zealot
hakan42 is on a distinguished road
 
hakan42's Avatar
 
Posts: 136
Karma: 60
Join Date: Jul 2009
Location: Munich, Germany
Device: Nook Classic rooted; Galaxy S IV with Aldiko, other older devices
Search for a book with only goodreads id does not work, you have to add at least the title.

One of my older books had the title "Dark Imperium", and "Unknown" as author. I used the "Link to goodreads..." menu item to add the id "goodreads:588334" to that book, then went into the "Edit Metadata" dialog and tried to download metadata. The Goodreads Metadata plugin failed to return any data:


Code:
****************************** Goodreads ****************************** 
Request extra headers: [('User-agent', 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0.1) Gecko/20100101 Firefox/4.0.1')] 
Found 0 results 
Downloading from Goodreads took 0.551999807358 
Goodreads book url: u'http://www.goodreads.com/book/show/588334'
Could not find title/authors/goodreads id for u'http://www.goodreads.com/book/show/588334'
Goodreads: u'588334' Title: 'Dark Imperium (Warhammer 40,000 Novels\n          \n            (Warhammer 40,000)' Authors: None 

********************************************************************************
What I don't really understand is, according to the plugin source (version 1.0.6), __init__.py, the plugin should not perform a search if the goodreads_id is available and good:

Code:
        goodreads_id = identifiers.get('goodreads', None)
        isbn = check_isbn(identifiers.get('isbn', None))
        br = self.browser
        if goodreads_id:
            matches.append('%s/book/show/%s'%(Goodreads.BASE_URL, goodreads_id))
        else:
hakan42 is offline   Reply With Quote