|
That change makes sense, assuming I understand what is happening (a dangerous assumption). It calls 'done' on the same thread that runs the job, which is the right thing to do, and perhaps makes the is_gui_thread changes in FunctionDispatcher irrelevant. It clearly does not dequeue the next job until done.
Regardless of whether or not this fixes meme's problem, it is a good change, clarifying the semantics of DeviceJob termination.
|