View Single Post
Old 04-03-2011, 05:31 AM   #47
kiwidude
calibre/Sigil Developer
kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.kiwidude ought to be getting tired of karma fortunes by now.
 
Posts: 4,230
Karma: 1345754
Join Date: Oct 2010
Location: London, UK
Device: Kindle Paperwhite 3G, iPad 3, iPad Air
@Loeffel - the reason why it doesn't get that ISBN number is because it contains a mixture of dashes and periods. Previous posts have questioned whether people had seen this situation - obviously you have now found such a case (most likely given your pasted text due to it being a European edition of a book).

Your "counter stays on 1" comment - do you mean it only finds one ISBN on all your books? In which case yes this is due to the regex.

As I have posted several times I took the regex used by this plugin from someone else's extract ISBN script on the assumption that it was an evolution of many people's attempts over time before it. Clearly it was not as "proven" as we would like given these variations from yourself and drMerry. I'll take a fresh look at that part of it over the next few days, including what drMerry has been experimenting with.

What would be extremely useful is a list of test case ISBNs of variations people have seen - if people could please post these (either stick them in a text file attachment or just post directly in the thread, either will be fine). That way I can make sure the next implementation will cater for your examples.

Last edited by kiwidude; 04-03-2011 at 05:33 AM.
kiwidude is offline   Reply With Quote